Re: [PATCH 2/7] core: Add API to handle "content-changed" signal
- From: "Juan A." Suárez Romero <jasuarez igalia com>
- To: grilo-list gnome org
- Subject: Re: [PATCH 2/7] core: Add API to handle "content-changed" signal
- Date: Wed, 02 Feb 2011 08:28:17 +0100
On Wed, 2011-02-02 at 07:14 +0000, Iago Toral wrote:
>
> For consistency, I would rather have:
>
> g_return_val_if_fail (grl_media_source_supported_operations
> (GRL_METADATA_SOURCE (source)) &
> GRL_OP_NOTIFY_CHANGED, FALSE);
>
> and remove the if() checking for the presence of notify_changed_stop
> below, just like in notify_start.
In this case, keeping consistency with other functions, we should also
the extra GError parameter, shouldn't we?
J.A.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]