Re: [PATCH 01/15] filesystem: adapted plugin to API change for GrlOperationOptions.
- From: Guillaume Emont <guijemont igalia com>
- To: grilo-list <grilo-list gnome org>
- Subject: Re: [PATCH 01/15] filesystem: adapted plugin to API change for GrlOperationOptions.
- Date: Wed, 14 Dec 2011 14:24:28 +0100
Excerpts from Juan A. Suarez Romero's message of Mon Dec 12 19:18:29 +0100 2011:
> On Fri, 2011-12-09 at 17:43 +0100, Guillaume Emont wrote:
> > Yeah, and the thing is, all the code that uses tab in there seems to
> > assume
> > that the width of a tab is 8 characters, and the indentation of my
> > changes is
> > correct and consistent with tabs of that width. I agree it breaks
> > things with
> > editors set to tabs of 4 chars, but then, the indentation of the whole
> > code
> > around is already broken anyway. So, unless anyone raises his voice, I
> > think I
> > will just be lazy and not change these bits.
>
> I'm using tabs of 3-chars, and all works fine for me.
>
> I think the problem raises when using tabs for other thing than
> indenting: aligning.
>
> There's a package for emacs, SmartTabs, that handles spaces/tabs as it
> should in source code: use tabs for indenting, spaces for aligning.
I think that idea does not work in practice, but I don't want to feed that
troll ;).
>
> Anyway, I'm not using that in Grilo, and all my tabs are converted to
> spaces.
That's the way it should be.
Guij
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]