Re: [PATCH 01/15] filesystem: adapted plugin to API change for GrlOperationOptions.



Excerpts from Simon Pena's message of Thu Dec 08 20:31:54 +0100 2011:
> It seems that this file also mixes spaces and tabs.
> 
> I'll be outlining them, but I agree with your comments in -core, and
> don't think that removing the tabs is a good enough reason to alter the
> git history that much.

Yeah, and the thing is, all the code that uses tab in there seems to assume
that the width of a tab is 8 characters, and the indentation of my changes is
correct and consistent with tabs of that width. I agree it breaks things with
editors set to tabs of 4 chars, but then, the indentation of the whole code
around is already broken anyway. So, unless anyone raises his voice, I think I
will just be lazy and not change these bits.

Also, I have done the changes suggested by your other email (regarding
get_caps()), and have pushed them in the same way as for core ("fixup!"
commits) on the "caps_and_options" branch of my grilo-plugins repo on
gitorious.

Guij


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]