Re: [PATCH 07/15] core: use GrlOperationOptions in grl_metadata_source_resolve()

Excerpts from Juan A. Suarez Romero's message of Mon Dec 12 14:28:59 +0100 2011:
> On Fri, 2011-12-02 at 18:36 +0100, gemont igalia com wrote:
> > -  rs->flags = flags;
> > +  rs->options = options; 
> Shouldn't we ref options and unref it later when freeing the spec?
> Otherwise, there's a chance that user frees the options after invoking
> the method.

Indeed we should. Corrected with a fixup in my gitorious branch, thanks for
catching this.
> The other choice is just keep saving flags instead the full options.
> After all, we only need that option in the whole resolve() function.

We might need the options structure around there for the implementation of
future options, so I'd rather transmit it already for "future simplicity",
considering that it doesn't cost much.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]