Re: [PATCH 07/15] core: use GrlOperationOptions in grl_metadata_source_resolve()

On Fri, 2011-12-02 at 18:36 +0100, gemont igalia com wrote:
> -  rs->flags = flags;
> +  rs->options = options; 

Shouldn't we ref options and unref it later when freeing the spec?

Otherwise, there's a chance that user frees the options after invoking
the method.

The other choice is just keep saving flags instead the full options.
After all, we only need that option in the whole resolve() function.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]