Re: [PATCH 4/6] Serialize all properties

[Iago Toral <itoral igalia com>]

Comment below

On Fri, 28 May 2010 11:15:07 +0200, Víctor M. Jáquez L.
<vjaquez igalia com> wrote:
> Comments on line,
> 
> On Fri, May 28, 2010 at 10:50:52AM +0200, Juan A. Suarez Romero wrote:
>> This is an improvement in serialize() function.
>> 
[...]

>> -  g_free (escaped_id);
>> -  g_free (escaped_source);
>> +  /* Include all properties */
>> +  if (full) {
>> +    g_string_append_c (serial, '?');
>> +    registry = grl_plugin_registry_get_instance ();
>> +
>> +    keylist = grl_metadata_key_list_new (GRL_METADATA_KEY_TITLE,
>> +                                         GRL_METADATA_KEY_URL,
>> +                                         GRL_METADATA_KEY_ARTIST,
>> +                                         GRL_METADATA_KEY_ALBUM,
>> +                                         GRL_METADATA_KEY_GENRE,
>> +                                         GRL_METADATA_KEY_THUMBNAIL,
>> +                                         GRL_METADATA_KEY_AUTHOR,
>> +                                         GRL_METADATA_KEY_DESCRIPTION,
>> +                                         GRL_METADATA_KEY_LYRICS,
>> +                                         GRL_METADATA_KEY_SITE,
>> +                                         GRL_METADATA_KEY_DATE,
>> +                                         GRL_METADATA_KEY_MIME,
>> +                                         GRL_METADATA_KEY_LAST_PLAYED,
>> +                                         GRL_METADATA_KEY_DURATION,
>> +                                         GRL_METADATA_KEY_CHILDCOUNT,
>> +                                         GRL_METADATA_KEY_WIDTH,
>> +                                         GRL_METADATA_KEY_HEIGHT,
>> +                                         GRL_METADATA_KEY_BITRATE,
>> +                                         GRL_METADATA_KEY_PLAY_COUNT,
>> +                                         GRL_METADATA_KEY_LAST_POSITION,
>> +                                         GRL_METADATA_KEY_FRAMERATE,
>> +                                         GRL_METADATA_KEY_RATING,
>> +                                         NULL);

Please don't do this :)
Add API in grl-plugin-registry.[ch] to obtain the list of registered keys instead.

Iago