Re: [PATCH] Problems when creating URLs with limits
- From: "Juan A. Suarez Romero" <jasuarez igalia com>
- To: Xabier Rodriguez Calvar <xrcalvar igalia com>
- Cc: grilo-list gnome org
- Subject: Re: [PATCH] Problems when creating URLs with limits
- Date: Fri, 11 Jun 2010 12:23:13 +0200
On Fri, 2010-06-11 at 10:49 +0100, Xabier Rodriguez Calvar wrote:
> Do you think this should be fixed? Which way?
IMHO, here there are two issues to fix:
* Some services have a limit in max. elements to retrieve.
* Some services have defined their max_count as a gint, while in Grilo
we are using a guint.
For first issue, I think the automatic threshold should be used. It was
added precisely because Youtube has this limit.
For second issue, I think max_count value passed to plugin should be
clamp to [0, G_MAXINT] before being used in the service. This would
avoid the problem of overflowing the number and getting a negative one.
J.A.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]