Re: [PATCH 2/6] [grl-plugin-registry] Use a hashtable for plugins' info



Hi,

On Wed, 2010-06-09 at 14:35 +0200, Juan A. Suarez Romero wrote:
> On Wed, 2010-06-09 at 10:14 +0200, Joaquim Rocha wrote:
> > -  const gchar *site;
> > +  GHashTable *optional_info;
> >    gint rank;
> 
> This is a picky and subjective comment: I would prefer to name it info
> instead of optional_info.
> 
> Otherwise, everytime I see optional_info I think there is also an info
> or compulsory_info field too. :)

I disagree, the struct where that hash table is in is called info, so
info.info would look weirder to me.

--
Joaquim Rocha

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]