Re: [PATCH 5/6] [grl-media-plugin] Use grl_media_plugin_get_info to retrieve default info

["Juan A. Suarez Romero" <jasuarez igalia com>]

On Wed, 2010-06-09 at 10:14 +0200, Joaquim Rocha wrote:
> diff --git a/src/grl-media-plugin.c b/src/grl-media-plugin.c
> index 6378931..539be9d 100644
> --- a/src/grl-media-plugin.c
> +++ b/src/grl-media-plugin.c
> @@ -107,7 +107,7 @@ grl_media_plugin_get_name (GrlMediaPlugin *plugin)
>  {
>    g_return_val_if_fail (GRL_IS_MEDIA_PLUGIN (plugin), NULL);
>  
> -  return plugin->priv->info->name;
> +  return grl_media_plugin_get_info (plugin, GRL_MEDIA_PLUGIN_NAME);
>  }


Wouldn't it be better to use #defines as it is done in GrlMedia?

#define grl_media_plugin_get_name (plugin) \
   grl_media_plugin_get_info((plugin), GRL_MEDIA_PLUGIN_NAME)


	J.A.