Re: [PATCH 0/1] Makes metadata() function cancelable

[Iago Toral <itoral igalia com>]

On Mon, 12 Jul 2010 11:13:36 +0200, "Juan A. Suarez Romero"
<jasuarez igalia com> wrote:
> Hello.
> 
> This patch comes from a grilo-clutter-player author requirement: metadata()
> function should be cancelable.
> 
> Actually, I think this requirement makes sense: all asynchronous functions
> should be cancelable, or at least, allow plugins to do it.
> 
> It is true that this requirement is not as strong as in case of browse(),
> search() or query(), but still, having there is still a good idea if source
> want to add support for canceling a metadata() function.
> 
> Right now, no source in our official set is able to cancel a metadata()
> operation. But we could add it to them. How? Most appropriate place to add
> canceling is when reading content from web service. That is, most of sources
> are using GIO to read content. GIO operations can be cancelable. Thus, we could
> cancel the metadata() operation by canceling this GIO reading. It would make
> sense mainly if webservice is not responding, or network is veeery slow.

Yes I agree. In the beginning I did not want to spend time doing this because 
there were more important things to do, but now I think is a good time to add 
this feature.

Iago