Re: [PATCH] libgoffice should doesn't pass correct type to gsf_xml_gvalue_from_str()

From: Christian Neumair <cneumair gnome org>
To: Jody Goldberg <jody gnome org>
Cc: gnumeric-list <gnumeric-list gnome org>
Subject: Re: [PATCH] libgoffice should doesn't pass correct type to gsf_xml_gvalue_from_str()
Date: Sat, 11 Aug 2007 16:13:13 +0200

Am Freitag, den 10.08.2007, 14:44 -0400 schrieb Jody Goldberg:

On Fri, Aug 10, 2007 at 04:21:05PM +0200, Christian Neumair wrote:

gsf_xml_gvalue_from_str() must know the precise type for G_TYPE_ENUM-
and G_TYPE_FLAGS-derived types, and not just its fundamental type. Thus,
goffice shouldn't pass the fundamental type but the actual object type
to gsf_xml_gvalue_from_str(). Otherwise, libgsf can't read enums and
flags from XML files.

 (...)
Proposed patch attached.


Please commit to trunk and the 0.4 branch.


Done.

-- 
Christian Neumair <cneumair gnome org>

References:
- [PATCH] libgoffice should doesn't pass correct type to gsf_xml_gvalue_from_str()
  - From: Christian Neumair
- Re: [PATCH] libgoffice should doesn't pass correct type to gsf_xml_gvalue_from_str()
  - From: Jody Goldberg

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]