Re: Patch for paradox write support

[uwe steinmann cx (Uwe Steinmann)]

On Thu, Feb 02, 2006 at 09:38:19AM -0500, Morten Welinder wrote:
> The best thing to do at this point would be to open up a bugzilla entry.
> Bugzilla's memory is far better than the mailing list's.
Sounds reasonable.

> > - fixed miscalculation of date during 1899/12/31 and 1900/02/28
>
> Are you sure this did not create problems for dates after February 1900?
> Excel's incorrectly includes February 29, 1900.  (And you left the old
> offset in the comment.)
I checked it again. The comment was wrong but the calculation works.

> * Don't print to stderr.  Call g_warning instead.
Fixed.

> * It seems to me that memory is leaked on many of the error returns.
You are right. PX_delete() is now called when needed. PX_delete()
also takes care of the memory for pxf.

> * When you copy from the temporary file to gsf you allocate a 8192-byte
>    buffer, but use only 256.
Ups. Fixed.

I'll file a bug report with the new patch.

  Uwe

-- 
  MMK GmbH, Fleyer Str. 196, 58097 Hagen
  Uwe Steinmann mmk-hagen de
  Tel: +2331 840446    Fax: +2331 843920

Attachment: signature.asc
Description: Digital signature