Re: [patch] Euro bugginess in 1.0.x series

[Jody Goldberg <jody gnome org>]

On Mon, Mar 03, 2003 at 07:44:06PM +0100, Vladimir Klebanov wrote:
> Hi,
>
> I've been bugged for a long time by missing Euro support in the datasheet.
> I've got my locale, fonts, etc. right but the Euro symbol just wouldn't
> appear. Not even the "currency" symbol. ;)
>
> I tried 1.0.8, both latest SuSE RPMs and self-compiled. Yesterday I digged
> through the code and tracked it down. The problem seems to lie with the
> switch/case statement and (mis-) matching 8-bit characters. The attached
> patch solves this issue for me. Can someone please review it and include it
> into the source tree?
>
> Regards,
> Vladimir Klebanov
>
> Please CC me since I'm not on the list.
>
>
> -- 
> Vladimir Klebanov  --   unny rz uni-karlsruhe de
>                         http://www.stud.uni-karlsruhe.de/~unny
> PATIENCE, n.  A minor form of despair, disguised as a virtue.

> --- src/format.c      Mon Mar  3 05:02:45 2003
> +++ src/format.c      Mon Mar  3 05:02:51 2003
> @@ -1000,7 +1000,7 @@
>       info.has_fraction = entry->has_fraction;
>  
>       while (*format) {
> -             int c = *format;
> +             char c = *format;
>  
>               switch (c) {

Gack.  Good catch.  The patch is not quite right, but it does point
out that doing a switch on unsigned char and matching with literal
characters that tend to be signed will not work.  I'll patch for the
next stable release.

Thanks