range_list_foreach_full



Since I don't want to break something major, I don't want to fix something I believe to be an error:

In ranges.c in the code for range_list_foreach_full we have:

---------------------
       a = value->v_range.cell.a;
       b = value->v_range.cell.b;

       for (col = a.col; col <= b.col; col++)
           for (row = a.row; row < b.row; row++){
----------------------

which maens that the column of b belongs to the range over which we iterate but its row doesn't. I think that can't be right and it should be:

---------------------
       a = value->v_range.cell.a;
       b = value->v_range.cell.b;

       for (col = a.col; col <= b.col; col++)
           for (row = a.row; row <= b.row; row++){
----------------------

Am I right?

Andreas

--
Prof. Dr. Andreas J. Guelzow Assoc. Prof of Mathematics
Concordia University College of Alberta
http://www.math.concordia.ab.ca/aguelzow





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]