[GnomeMeeting-devel-list] Patch for Openh323 and gcc4

[Daniel Veillard <veillard redhat com>]

  Hi Damien and all,

Sorry it's not pure development informations, but since I had a patch
I though it was the right place to post.

I rebuilt pwlib-1.8.4 / openh323-1.15.3 / gnomemeeting-1.2.1 
for Fedora Core 4 with gcc4. It's nearly clean, the main problems
remaining are:
   - cast from pointers to int in openh323 that gcc4 considers a
     fatal error now (apparently it wasn't fixed in CVS as far as
     I can tell so patch enclosed)
   - the config.guess of pwlib is so old that doesn't seems to know
     about ppc64, maybe an update at the next release would be a good idea
   - removing symbol tables in pwlib/make/unix.mak break our debuginfo
     LDFLAGS += -s
     has to be removed in our build, no idea if it annoys anybody else

It seems to work :-) I tried a session between i686 and x86_64, i.e.
32 and 64 bits builds without apparent troubles.

W.r.t. packaging, I also recompiled 1.2.1 on RHEL4 (1.2.0 is shipped by
default), so it may also rebuild without troubles on FC3, tell me if this
is needed and who I should contact about packaging in that case,

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

*** openh323-1.15.3/src/vic/p64.cxx.orig	2005-03-18 11:52:49.146096610 +0100
--- openh323-1.15.3/src/vic/p64.cxx	2005-03-18 11:53:48.651046530 +0100
***************
*** 1125,1131 ****
  	 * If input buffer not aligned, prime bit-buffer
  	 * with 8 bits; otherwise, prime it with a 16.
  	 */
! 	if ((int)bp & 1) {
  		bs_ = (u_short*)(bp + 1);
  		bb_ = *bp;
  		nbb_ = 8 - sbit;
--- 1125,1131 ----
  	 * If input buffer not aligned, prime bit-buffer
  	 * with 8 bits; otherwise, prime it with a 16.
  	 */
! 	if ((u_long)bp & 1) {
  		bs_ = (u_short*)(bp + 1);
  		bb_ = *bp;
  		nbb_ = 8 - sbit;
*** openh323-1.15.3/plugins/audio/Speex/speexcodec.cxx.orig	2005-03-18 12:06:35.138471815 +0100
--- openh323-1.15.3/plugins/audio/Speex/speexcodec.cxx	2005-03-18 12:18:45.958321765 +0100
***************
*** 103,109 ****
  
  static void * create_encoder(const struct PluginCodec_Definition * codec)
  {
!   int mode = (int)(codec->userData);
  
    struct PluginSpeexContext * context = new PluginSpeexContext;
    context->bits = new SpeexBits;
--- 103,110 ----
  
  static void * create_encoder(const struct PluginCodec_Definition * codec)
  {
!   long model = (long)(codec->userData);
!   int mode = (int)model;
  
    struct PluginSpeexContext * context = new PluginSpeexContext;
    context->bits = new SpeexBits;