Re: [GnomeMeeting-devel-list] [PATCH] Sound Input only plugins?

[Damien Sandras <dsandras seconix com>]

Le mardi 05 avril 2005 à 17:38 +0900, Georgi Georgiev a écrit :

> > 2)
> > I don't understand this :
> > +  // FIXME: hide/show the output_plugin_menu... there has to be a
> > better way.
> > +  gm_conf_set_string (AUDIO_DEVICES_KEY "output_plugin",
> > +		  gm_conf_get_string(AUDIO_DEVICES_KEY "output_plugin"));
> 
> The hide/show logic is in "manager_changed_nt". This function is called
> when the {output,input}_plugin key is changed.
> 
> However, when the preferences widget is first initialized, there is no
> logic involved. In other words, you get the output_plugin menu unhidden
> (only initially) regardless whether it should be or not. If you change
> the input plugin, it will properly get hidden, but in the beginning it
> is always shown.
> 
> So, I forced an update on the "output_plugin" key, in order to call
> manager_changed_nt and hide/show the output_plugin menu. I thought it's
> ugly, but if you like it, feel free to remove the FIXME.
> 

That's indeed ugly ;)

> > Thanks!
> 
> Thank *you*. If that thing goes in I can safely work on the DV audio
> plugin. Improving the druid would indeed be useful, though, as it has
> the audio test feature that would greatly facilitate the work on an
> audio plugin.
> 

It will go in, however, only in the OPAL branch as explained earlier,
and this branch doesn't support video yet. As it is not a bugfix, it can
not go in the gnome-2-10 branch, and 1.2 will be the latest release to
support openh323, so the only logical choice is the opal branch. I hope
that it is ok with you.
-- 
 _      Damien Sandras
(o-     GnomeMeeting: http://www.gnomemeeting.org/
//\     FOSDEM 2005 : http://www.fosdem.org
v_/_    H.323 phone : callto:ils.seconix.com/dsandras seconix com