Re: [GnomeMeeting-devel-list] Zeroconf support

[PUYDT Julien <jpuydt free fr>]

Le dimanche 14 novembre 2004 à 19:58 +0100, Damien Sandras a écrit :
> there is still one crash when you change your info and click on Apply or
> make a call. That doesn't always happen, I'm investigating.

I don't know about that crash, but this patch modifies some comments.

Notice too:
* I don't understand why GetPersonalData is set to return an int since
it doesn't seem to be used that way ;
* I don't really like the way the lock is taken, then the personal data
is gotten and added to the text record step by step, then the lock is
released. I would rather see more local variables, take the lock, get
the personal data, release the lock and only then build the text record.

I only read the publisher so far, but it looks quite nice apart from
that ;-)

Snark

diff -ur gnomemeeting/src/zeroconf_publisher.cpp gnomemeeting.patched/src/zeroconf_publisher.cpp
--- gnomemeeting/src/zeroconf_publisher.cpp	2004-11-14 17:59:28 +0100
+++ gnomemeeting.patched/src/zeroconf_publisher.cpp	2004-11-15 05:39:07 +0100
@@ -99,8 +99,8 @@
 
 /* DESCRIPTION  : / 
  * BEHAVIOR     : GMZeroconfPublisher destructor
- *		  -release the discovery zeroconf session
- * PRE          : must be call to finish zeroconf session
+ *		  - release the discovery zeroconf session
+ * PRE          : must be called to finish zeroconf session
  */
 
 GMZeroconfPublisher::~GMZeroconfPublisher()
diff -ur gnomemeeting/src/zeroconf_publisher.h gnomemeeting.patched/src/zeroconf_publisher.h
--- gnomemeeting/src/zeroconf_publisher.h	2004-11-13 19:37:52 +0100
+++ gnomemeeting.patched/src/zeroconf_publisher.h	2004-11-15 05:39:39 +0100
@@ -51,7 +51,7 @@
 
 /* 
  * Redefine some howl struct because of a bug in howl 
- * including config.h that conflish with GM config.h
+ * including config.h that conflicts with GM config.h
  */
 struct _sw_discovery;
 typedef struct _sw_discovery *sw_discovery;
@@ -77,7 +77,7 @@
 
   /* DESCRIPTION  : / 
    * BEHAVIOR     : ZeroconfPublisher destructor
-   *		    -Rrelease the discovery zeroconf session
+   *		    - release the discovery zeroconf session
    * PRE          : /
    */
   ~GMZeroconfPublisher ();
@@ -85,8 +85,8 @@
 
   /* DESCRIPTION  : / 
    * BEHAVIOR     : Return -1 when error occured, 0 else.
-   *		  Start the thread
-   * PRE          : No comment!
+   *		    Start the thread
+   * PRE          : /
    * 		  
    */
   int Start ();
@@ -114,8 +114,8 @@
 
   /* DESCRIPTION  : / 
    * BEHAVIOR     : Return err=SW_OKAY when no error occured.
-   *		  Retrieve user personal data from gconf 
-   *		  to class attributes info.
+   *		    Retrieve user personal data from gmconf 
+   *		    to class attributes info.
    * PRE          : must be call to update personal data
    */
   int GetPersonalData();