Re: [PATCH 10/15] gnome-control-center: Font size reduction

[Bryce Harrington <bryce canonical com>]

On Thu, Apr 10, 2008 at 10:07:22PM +0100, Thomas Wood wrote:
> On Thu, 2008-04-10 at 21:08 +0100, Bastien Nocera wrote:
> > On Thu, 2008-04-10 at 13:00 -0700, Bryce Harrington wrote:
> > > gnome-control-center:  108_cc-randr12-capplet-font-layout.patch (LP:
> > > #201589)
> > > 
> > > Cosmetic issue.  Shrinks font size from 16 to 12 so long monitor names
> > > fit within bounding boxes.
> > 
> > Your patch is reversed.
> 
> Also, can I ask why font sizes are being hard coded into an application?
> This is usually very bad practise, unless there is a specific reason. I
> don't know this code at all, so perhaps someone could enlighten me,

Along with fonts, colors are also being hard coded.  For Ubuntu I
changed them to something more in line with our defaults, but it would
be nice if these could be derived from the currently set theme.  (One of
our desktop guys gave me some suggestions on doing this, but I just ran
out of time before I could research/implement).

Anyway, I don't think the hardcodings are intentional, just refinements
that no one has gotten to yet.

Bryce