Re: [PATCH] some performance improvements

[Rodrigo Moya <rodrigo novell com>]

On Fri, 2005-10-14 at 12:58 -0400, Rodney Dawes wrote:
> Generally looks ok.
> 
> It looks like all of the code in gnome_settings_xrdb_init () is being
> removed. Is there any particular reason to keep the function around, but
> empty?
> 
not, apart from having the _init/_load that all other modules have.

> When does the window created in gnome_settings_xrdb_load () get
> destroyed? Are we not leaking it? There are no calls to any unref or
> destroy methods in the current code, so I presume we are, no?
> 
yes, seems so. I didn't want to touch much of that code, apart from
Erwann's patch, because I think we can mix all the calls there are to
xrdb (gnome-settings-xrdb.c, gnome-settings-xsettings.c and
gnome-settings-font.c) in one place, to be able to run xrdb only once on
startup.

> Then again, I would also wonder if there is any particular reason to
> keep xrdb merging around at all. How many applications on a normal
> desktop actually need this stuff?
> 
see Ben's list :)

I have removed those calls in my local tree, and things go much quicker,
so if it were for me, I'd remove them, but seems we really need for all
those apps.

> As for the 2.12 stuff, perhaps we should get some testing done with it
> in HEAD first? Would be nice to really test not doing xrdg -merge at all
> as well.
> 
ok, will commit all performance patches to HEAD only, and when we are
happy, I'll commit them to the 2.12 branch.
-- 
Rodrigo Moya <rodrigo novell com>