Re: [PATCH] Duplicated screensaver entry in control center

[Rodrigo Moya <rodrigo novell com>]

On Fri, 2005-10-14 at 12:42 -0400, Rodney Dawes wrote:
> +               /* FIXME: discard xscreensaver if gnome-screensaver is
> installed */
> 
> Why does this patch ADD a FIXME I wonder. In general the goal should be
> to not have FIXMEs at all, rather than to add more, for new
> functinality. Perhaps it should just be the same comment without the
> FIXME bit?
> 
right, was a leftover from my first patch.

> Also, shouldn't we check for gnome-screensaver-preferences instead of
> the server process?
>
yes, changed that also.

>  Ideally though, I suppose we should check for
> which of the two server processes is actually running, and only show
> the appropriate preferences for that server.
> 
well, the screensaver might not be running, if disabled. So, I guess it
is better to do what the other modules (panel, gdm, settings daemon) do,
which is to use always gnome-screensaver if installed.

> Other than those two minor things, it looks ok though, and I would say
> we should put it in 2.12 as well.
> 
committed to both branches with the above mentioned changes.
-- 
Rodrigo Moya <rodrigo novell com>