Re: [PATCH] Duplicated screensaver entry in control center

[Rodney Dawes <dobey novell com>]

+               /* FIXME: discard xscreensaver if gnome-screensaver is
installed */

Why does this patch ADD a FIXME I wonder. In general the goal should be
to not have FIXMEs at all, rather than to add more, for new
functinality. Perhaps it should just be the same comment without the
FIXME bit?

Also, shouldn't we check for gnome-screensaver-preferences instead of
the server process? Ideally though, I suppose we should check for
which of the two server processes is actually running, and only show
the appropriate preferences for that server.

Other than those two minor things, it looks ok though, and I would say
we should put it in 2.12 as well.

-- dobey

On Fri, 2005-10-14 at 12:58 +0200, Rodrigo Moya wrote:
> Hi
> 
> Attached patch was submitted to bugzilla a month ago. It makes the
> control center not show the xscreensaver capplet icon if
> gnome-screensaver is installed (all other gnome modules run g-s if
> installed, if not, xscreensaver).
> 
> I think this should also get into the 2.12 branch. Ok?