Re: LOCK AND LOAD!
- From: Peter Bowen <pzb ximian com>
- To: GNOME Web Hackers <gnome-web-list gnome org>
- Subject: Re: LOCK AND LOAD!
- Date: 19 Jul 2003 10:24:23 -0400
On Fri, 2003-07-18 at 21:44, Jeff Waugh wrote:
> There are a few things anyone can do, which will please more people that
> it may inconvenience, so you're welcome to do these at any time:
>
> - Fixing up typos such as spelling and grammar mistakes
>
> - Fixing up broken html bits
>
> - Fixing up standards-breaking pages
>
> - Eliminating EVIDENCE OF EVIL such as images-as-text, font tags, and
> anything else that doesn't help us shift towards XHTML Strict
>
> Otherwise, please mail gnome-web-list gnome org and ask for permission.
That attached patch fixes the index page to validate (it was missing a
</a>), changes the php open tag to <?php from <? (needed if we switch to
xhtml), and a few PHP formatting fixes. I think that all the changes
qualify under one or more of the above automatic approval categories,
but I wanted to make sure.
Thanks.
Peter
Index: index.wml
===================================================================
RCS file: /cvs/gnome/gnomeweb-wml/www.gnome.org/index.wml,v
retrieving revision 1.68
diff -u -r1.68 index.wml
--- index.wml 18 Jul 2003 18:46:34 -0000 1.68
+++ index.wml 19 Jul 2003 14:05:59 -0000
@@ -22,7 +22,7 @@
<tr>
<td><img src="images/computer.png" width="48" height="48" alt="GNOME 2"></td>
<td><a href="/pr-extremadura.html">The regional government of Extremadura, Spain has put 80,000 computers in schools, loaded with GNOME,
-Linux and other free software!</td>
+Linux and other free software!</a></td>
</tr>
<tr>
<td><img src="images/gnome2.png" width="48" height="48" alt="GNOME 2"></td>
@@ -51,15 +51,15 @@
<table border='0' cellspacing='0' cellpadding='0'><tr><td>
-<?
-
-if (filectime("recentapps-cache.html") < (time() - 300)) { # If cache is older than 5 minutes
+<?php
+# If cache is older than 5 minutes
+if (filectime("recentapps-cache.html") < (time() - 300)) {
$tempfilename = tempnam("/tmp", "appcache");
- $tmpfd = fopen( $tempfilename, "w");
+ $tmpfd = fopen($tempfilename, "w");
- Include("/home/admin/applist/private.php3");
+ include("/home/admin/applist/private.php3");
mysql_select_db("gnomeweb");
$query = "SELECT groups.group_name AS group_name,"
@@ -86,7 +86,7 @@
mysql_close();
fclose($tmpfd);
- copy($tempfilename, "recentapps-cache.html");
+ copy($tempfilename, "recentapps-cache.html");
unlink ($tempfilename);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]