Re: Wrong mime-type for folders over FTP

[Christian Neumair <chris gnome-de org>]

Am Samstag, den 06.01.2007, 17:12 -0800 schrieb Micah Carrick:
> Not sure if this is already known... but I'm experiencing some problems 
> with GnomeVFS over FTP connections. Folders are coming back as 
> application/octet-stream rather than x-folder/normal and thus the icons 
> in Nautilus are all the "unknown" icon rather than folder icons.
> 
> I'm using gnome-vfs-2.16.2 on Gnome 2.16.0 (Fedora Core 6).

Thanks for the bug report.

I just reverted a part of the patch that was meant to fix a crash, see
bug 330625 [1].

It passed the permissions field of the FTP file info to
gnome_vfs_get_mime_type_from_mode() instead of using the info
encapsulated into a stat struct.

Note: For the SFTP method, file_info->permission holds more than just
the access rights; it includes the file modes - I just copied over the
code from SFTP to FTP and didn't realize that, so it broke for FTP.

The SFTP code is obviously wrong as it provides undocumented field
values.


[1] http://bugzilla.gnome.org/show_bug.cgi?id=330625

-- 
Christian Neumair <chris gnome-de org>