Re: gnome_vfs_uri_hash() bug?

[Alexander Larsson <alexl redhat com>]

On Sun, 2006-06-04 at 12:51 -0700, Ken Ishii wrote:
> gnome_vfs_uri_hash() has the following code section:
> 
>   for (uri_p = uri; uri_p != NULL; uri_p = uri_p->parent) {
>     HASH_STRING (hash_value, uri_p->text);
>     HASH_STRING (hash_value, uri_p->method_string);
> 
>     if (uri_p->parent != NULL) {
>       const GnomeVFSToplevelURI *toplevel;
> 
>       toplevel = (const GnomeVFSToplevelURI *) uri_p;
> 
> Since GnomeVFSToplevelURI is defined to be an URI without a parent,
> shouldn't
> if (uri_p->parent != NULL)
> be
> if (uri_p->parent == NULL)
> instead?

Yeah. That looks wrong. I'm fixing it in cvs. Thanks.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an old-fashioned white trash romance novelist She's a bloodthirsty 
Buddhist bodyguard prone to fits of savage, blood-crazed rage. They fight 
crime!