Re: Adding API for editing GnomeVFSVolume's

[Alexander Larsson <alexl redhat com>]

On Thu, 2005-09-15 at 18:52 +0200, Christian Neumair wrote:
> Am Donnerstag, den 15.09.2005, 18:17 +0200 schrieb Christian Neumair:
> > We may want to add "uri", "icon" and "activation-uri" properties, so that
> > clients can connect "notify::icon" and such.
> 
> To allow simple global volume monitoring, and be consistent with the
> current semantics, we can also connect to "notify" events from volumes
> inside the volume monitor and emit a "volume-changed" event.
> However, I'm concerned that we can't simply add this new field to
> GnomeVFSVolumeMonitorClass, since this would be an ABI breakage. Are we
> willing to accept this breakage, taken that subclassing the monitor
> would be dumb? I really wonder why we expose the GnomeVFSVolumeMonitor
> structs at all. Making them opaque for the outside world would be better
> IMHO.

There is no ABI breakage in this, the volume monitor is a singleton and
can't be allocated by the user, so changing its size doesn't break
things. However, there may be some breakage in the gnome-vfs ipc
protocol to implement the sending of these signals from the daemon to
the clients (and from client to daemon when the change happens). We
don't really guarantee that an old gnome-vfs daemon works well with a
new gnome-vfs library (since the daemon is auto-started from the
library), but it can still happen for some people on upgrades.

Anyway, as I said earlier in the thread this is sort of complicated, as
it needs work on the whole locking model of the volume monitor.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an unconventional Amish romance novelist who hangs with the wrong crowd. 
She's a radical out-of-work snake charmer from aristocratic European stock. 
They fight crime!