Re: gnome-vfs-sftp 0.1.2

[Alexander Larsson <alexl redhat com>]

On 20 Mar 2003, Bradford Hovinen wrote:

> On Wed, 2003-03-05 at 07:14, Alexander Larsson wrote:
> > I got a deadlock. I think this fixes it:
> > --- sftp-method.c.deadlock	2003-03-05 12:28:35.000000000 +0100
> > +++ sftp-method.c	2003-03-05 12:30:22.000000000 +0100
> > @@ -1653,6 +1653,7 @@
> >  		if (status != SSH2_FX_OK) {
> >  			buffer_free (&msg);
> >  			g_free (write_req);
> > +			sftp_connection_unlock (handle->connection);
> >  			return sftp_status_to_vfs_result (status);
> >  		}
> >  
> > @@ -1752,8 +1753,10 @@
> >  	if (options & GNOME_VFS_FILE_INFO_FOLLOW_LINKS) {
> >  		res = get_real_path (conn, path, &real_path);
> >  
> > -		if (res != GNOME_VFS_OK)
> > +		if (res != GNOME_VFS_OK) {
> > +			sftp_connection_unlock (conn);
> >  			return res;
> > +		}
> >  	}
> >  	else
> >  		real_path = path;
> > 
> > 
> > The error handling when you've note got the key for the server in 
> > ssh-agent needs to be better too.
> 
> Sorry for taking so long to get back to you. I applied your patch --
> thanks.
> 
> I am unclear what you mean by this last statement. I tested cases where
> the server key is not in known_hosts, where the user's public key is not
> on the server's authorized_keys, and where the user's public key is on
> the server's authorized_keys but the private key is not loaded into
> ssh-agent. All seemed to work for me in the sense that the error
> messages reported seem to be appropriate. What specific trouble are you
> having?

If i type sftp://localhost/ i get the warning:

** (nautilus:11780): WARNING **: in nautilus-applicable-views.c, got 
unhandled GnomeVFSResult 6 (I/O error). If this is a legitimate 
get_file_info result, please tell sullivan eazel com so he can write a 
decent user-level error message for it.

Maybe we can pick a better vfs result messsage for this failure.

The cause seem to be:
# sftp localhost
Connecting to localhost...
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@    WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!     @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
IT IS POSSIBLE THAT SOMEONE IS DOING SOMETHING NASTY!
Someone could be eavesdropping on you right now (man-in-the-middle attack)!
It is also possible that the RSA host key has just been changed.
The fingerprint for the RSA key sent by the remote host is
51:69:bb:26:97:d7:e4:99:de:75:97:f9:f6:54:39:69.
Please contact your system administrator.
Add correct host key in /home/alex/.ssh/known_hosts to get rid of this message.
Offending key in /home/alex/.ssh/known_hosts:11
RSA host key for localhost has changed and you have requested strict checking.
Host key verification failed.
Couldn't read packet: Connection reset by peer

If i type sftp://192.168.0.10/ (my machine, which has no keys set up) I 
get a password prompt on the terminal I started nautilus on. I have to 
press enter three times on it to get the error message.
 
> With the resolution of this issue, I think I will put out 0.1.3 unless
> there are other pending problems. What are your thoughts on including
> this in gnome-vfs?

I think its time to add this to gnome-vfs, although we probably want to 
branch off gnome-2-2 first and keep the new stuff on the 2.3 branch.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a fast talking devious astronaut looking for 'the Big One.' She's a 
cold-hearted cat-loving fairy princess operating on the wrong side of the law. 
They fight crime!