On Wed, 2003-02-12 at 07:05, Alexander Larsson wrote: > I looked a bit at this now, and in general it looks good. > > Comments: > > Instead of #ifdef VFS_BIG_ENDIAN use G_BYTE_ORDER > > in launch_ssh() use g_spawn_async_with_pipes instead. It has better error > reporting and stuff. All noted. My next version will incorporate your suggested changes. > One perhaps major problem is the OpenSSH license: > > /* > * Copyright (c) 2001 Markus Friedl. All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > * modification, are permitted provided that the following conditions > * are met: > * 1. Redistributions of source code must retain the above copyright > * notice, this list of conditions and the following disclaimer. > * 2. Redistributions in binary form must reproduce the above copyright > * notice, this list of conditions and the following disclaimer in the > * documentation and/or other materials provided with the distribution. > * > * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR > * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES > * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. > * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, > * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > */ > > Is that actually compatible with the LGPL? As you mentioned in your subsequent message, this looks like a standard BSD-style license -- I looked through it and couldn't find anything that seemed LGPL-incompatible. -- Bradford Hovinen http://www.math.uwaterloo.ca/~bghovinen/ School of Computer Science Email: bghovinen math uwaterloo ca University of Waterloo Office: Davis Centre 3527 Waterloo, ON, N2L 3G1 Canada Phone: (519) 888-4567 x3581
Attachment:
signature.asc
Description: This is a digitally signed message part