Re: patch for gnome_vfs_get_mime_type_internal
- From: Michael Meeks <michael ximian com>
- To: Christophe Fergeau <teuf users sourceforge net>
- Cc: gnome-vfs-list gnome org
- Subject: Re: patch for gnome_vfs_get_mime_type_internal
- Date: 06 Nov 2002 08:50:45 +0000
Hi Christophe,
On Tue, 2002-11-05 at 14:24, Christophe Fergeau wrote:
> Here is a patch which cleans up a little
This is really nice stuff, makes the code far clearer and legible.
Great work, please commit.
> While debugging this patch, I noticed that when reading a directory,
> Nautilus would sniff the mime type for a given file 2 or 3 times (one
> when it uses read_directory, and a second time when using
> get_file_info). Maybe that could be improved to be done only once, I'll
> look at that.
That's really bad - mime sniffing is deadly expensive; any insight you
have there would be great, although you'll have to get into unwinding
the existing nautilus caches to stop that sort of thing happening ;-)
Regards,
Michael.
--
mmeeks gnu org <><, Pseudo Engineer, itinerant idiot
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]