Re: Stop installing/updating apps in parallel

[Joaquim Rocha <jrocha endlessm com>]

Hey,

On Mon, Jan 15, 2018 at 8:58 PM, Richard Hughes <hughsient gmail com> wrote:

I think we have to support one or the other. Architecturally, we can
either do this in a few different ways:

 * In the plugin loader to serialize the GsApp during Install
 * In the flatpak plugin directly

Let's not do this. This should be global to g-s, as installing apps can obviously use several plugins. And actually apart from the processing penalty, Flatpak should be one of the plugins that behaves better when run in parallel in any case.

 

 * Have a scheduler object that we can offload the queue out of the
plugin loader
 * Just mark apps install buttons as insensitive until the current app
has finished installing
 * Use the "pending" queue to do this 

I do think it has to be architecturally simple, and it certainly needs tests.

I think we have to do it in the plugin loader, likely by doing:

1) if the action is to be queued (install/update/maybe-remove), we add the task corresponding to the action to a queue

2) then we should have another task that consumes the queue, the consumer task should maybe finish when the queue is empty (so we just have to start it again when a new action arrives)

Maybe this can replace the pending queue as you suggested too.

Cheers,

Joaquim Rocha  |  Endless