Re: extensionUtils: Load extensions asynchronously

Please file a bug. Thanks.

On Sat, Dec 22, 2012 at 4:20 PM, Norman L. Smith <nls1729 gmail com> wrote:

I was poking around GS3.7.3 and found what appears to be a bug or
atleast an issue that has not been addressed yet.
commit 6b40c3974d55c52e67c066da59febc34c6d7c92e
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri Nov 30 18:06:11 2012 +0100

extensionUtils: Load extensions asynchronously

Use the new collectFromDatadirsAsync() function for extension
loading as well.

The above commit breaks extensionPrefs/main.js.

When the gnome-shell-extension-prefs is executed with an extension
url or uuid as an argument the extensions are not loaded before
_extensionAvailable() is called in _onCommandLine in main.js. I did
not see a way to fix it properly in extensionPrefs/main.js.

I created a patch based on the old code which adds a synchronous scan
to the ExtensionFinder class in extensionUtils for use by callers who
need the extensions populated without delay.

If this issue is not in someone's queue or otherwise is not a problem,
let me know and I will file a bug with the patch.



gnome-shell-list mailing list
gnome-shell-list gnome org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]