Re: [clutter] gnome-shell / mutter / ARB_texture_rectangle

[Neil Roberts <neil linux intel com>]

Hi Owen,

On Fri, 2008-11-21 at 12:00 -0500, Owen Taylor wrote:

> I wanted to push some more on this.
> 
>  - What approach do I need to go with for a patch that will be accepted?
> 
>  - If that isn't clear, what research needs to be done and what
>    information needs to be provided?

I think the worry was that adding new API to Clutter to support
rectangle texture makes it look like they are first class citizens and
that they are fully supported. It also makes it difficult to remove the
support later on if it is no longer necessary.

I had a suggestion that we might be able to do it without adding any new
API if we internally support rectangle textures but only allow creating
CoglHandles to them via cogl_texture_new_from_foreign.

I've created two bug reports with changes to your patches to implement
this here:

http://bugzilla.openedhand.com/show_bug.cgi?id=1297

http://bugzilla.openedhand.com/show_bug.cgi?id=1298

ClutterGLXTexturePixmap uses this to create its own rectangle textures
directly using GL calls. This is probably a safe place to do direct
calls because it needs to call GLX directly anyway.

The other patch for Mutter detects whether the pixmap texture is
rectangle type and creates the mask as a rectangle texture if so. That
way the decision whether to use rectangle textures is still kept in the
texture-pixmap code.

Do you think that would be good enough?

Perhaps we should move any further discussion to the bug reports?

Regards,
- Neil