GNOME.org
 

Re: [gpm] Fixing icon compatibility [Was: Re: [Bug 617529] ]

Richard,

How did you test this?  Can you provide me with a way to run your exact test (perhaps in tarball form?).  The fix I provided you brought back my previous icons.

The behavior you are describing suggests that your "use-default-fallbacks" property is set to true.  Since mine appears to have worked, I'd assume that my "use-default-fallbacks" properties was still at its default: false.  Here's an excerpt from http://library.gnome.org/devel/gio/stable/GThemedIcon.html:

The "use-default-fallbacks" property

  "use-default-fallbacks"    gboolean              : Read / Write / Construct Only

Whether to use the default fallbacks found by shortening the icon name at '-' characters. If the "names" array has more than one element, ignores any past the first.

For example, if the icon name was "gnome-dev-cdrom-audio", the array would become 

1
2
3
4
5
6
7
 
{
  "gnome-dev-cdrom-audio",
  "gnome-dev-cdrom",
  "gnome-dev",
  "gnome",
  NULL
};

Default value: FALSE


--Brian

From: Richard Hughes <hughsient gmail com>
To: Brian Hutsell <bhut_ooto yahoo com>
Cc: GPM Mailing List <gnome-power-manager-list gnome org>; Jakub Steiner <jimmac gmail com>; Jon McCann <jmccann redhat com>
Sent: Wed, May 19, 2010 4:40:37 PM
Subject: Re: Fixing icon compatibility [Was: Re: [Bug 617529] ]

On 19 May 2010 04:16, Brian Hutsell <bhut_ooto yahoo com> wrote:
> Here's a patch that explicitly provides a prioritized list of icon names,
> including the new symbolic names as well as the previous names from
> GNOME_POWER_MANAGER_2_30_1.  This restores compatibility with the older icon
> names without adding any additional preferences or symbolic links.

I'm not sure it'll work in practice. For example:

battery-full;gpm-ups-full;gpm-ups-100; (non-symbolic)

with the following icons in the theme:

battery, battery-full-symbolic, gpm-ups-full

you get "battery"

You could argue this is a bug in gtkicontheme.c, and I would probably
agree with you. I'll talk to Matthias later today and find out if this
is expected behavior.

Richard

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]