Re: [gpm] Changing Backlight

[Richard Hughes <hughsient gmail com>]

Okay, initial review:

> +       gboolean                 old_system_is_idle;
> +       gboolean                 old_on_ac;

Is this "I used to be on AC before I was dimmed"?

> +               /* Never let going on battery turn off the display */
> +               if (brightness + scale < 0.05f) {
> +                       scale = 0.05f - brightness;

Turn off the display? Why is <5% off? 0% should be "low dim" not "off".

Other thank that it looks pretty good, thanks. I can;t test this for a
week or so (busted laptop....) but when I get one that works I'll give
it a spin.

Thanks.

Richard.