Re: proposed HIG patch

[Matt Davey <mcdavey mrao cam ac uk>]

On Tue, 2006-05-30 at 18:14 -0700, Nathan Owens wrote:
> I like the new look! It makes the program feel more "concrete".

Thanks.  Most of the layout credit is due to Daniel Thompson;  I
followed his lead fixing a couple of things he'd missed, and changed the
strings.

> A few suggestions:
add shortcuts.  got it. :)

> Those are the only changes I can see. I believe glade makes shortcut keys easy,
yes, it's trivial.  I'll have another hack on it when I get the chance.
I should manage to commit your patch tonight, at least.

> I did have a slight problem with gpilotd-capplet.glade - it's a patch against version 1.20 in CVS,
> and 1.21 is the latest

Ah, yes.  I'd forgotten that (it's a couple of weeks since I worked on
the HIG stuff.  Daniel's patch was against 1.20, so I took that as a
starting point and then backported the stuff I'd changed in 1.21
(related to the netsync stuff, so that we grey out the options that
aren't relevant to netsync).

> I also had to take out the GNOME_COMPILE_WARNINGS(error) in configure.in - there are still a lot
> of warnings. We'll have to work on that.

I fixed tons of warnings, mostly but not all trivial.  I think it should
compile without warnings on gcc 3.x.  gcc 4 throws up tons of new
warnings, particularly on signed/unsigned comparisons and the like.
Haven't worked on that, so won't be checking in -Werror... but it'd be
good to fix them all.

Thanks a mill, Nathan, for taking the time.  It can be quiet enough
around here sometimes.

Matt

Matt Davey   Science is to computer science as hydrodynamics is to plumbing.
mcdavey mrao cam ac uk 		       -- Stan Kelly-Bootle