Hi all, I've had a bit of trouble with crashes on various muds with 10.5, after a bit of investigation I found the problem only occurred with an mccp-enabled build on a 64-bit system. Attached is a patch that seems to solve the problem. It seems a little large to me for such a small fix, is there a better command to use for patches than "cvs diff -u"? Regards, -- Daniel Patton <seven-nation army com>
cvs server: Diffing gnome-mud Index: gnome-mud/ChangeLog =================================================================== RCS file: /cvs/gnome/gnome-mud/ChangeLog,v retrieving revision 1.324 diff -u -r1.324 ChangeLog --- gnome-mud/ChangeLog 11 Mar 2005 15:13:14 -0000 1.324 +++ gnome-mud/ChangeLog 13 Mar 2005 09:04:19 -0000 @@ -1,3 +1,8 @@ +2003-03-13 Daniel Patton <seven-nation army com> + + * src/net.c |read_from_connection|: Set string to NULL before freeing, + prevents crash while using mccp with 64 bit systems. + 2005-03-13 Robin Ericsson <lobbin localhost nu> * src/gnome-mud.h [connection_data]: Added member naws. cvs server: Diffing gnome-mud/doc cvs server: Diffing gnome-mud/doc/C cvs server: Diffing gnome-mud/doc/C/figures cvs server: Diffing gnome-mud/doc/gnome-mud-manual cvs server: Diffing gnome-mud/doc/gnome-mud-manual/C cvs server: Diffing gnome-mud/doc/gnome-mud-manual/C/figures cvs server: Diffing gnome-mud/doc/gnome-mud-plugin-api cvs server: Diffing gnome-mud/doc/gnome-mud-plugin-api/C cvs server: Diffing gnome-mud/doc/omf-install cvs server: Diffing gnome-mud/doc/python cvs server: Diffing gnome-mud/doc/python/gnome-mud cvs server: Diffing gnome-mud/doc/python/gnome-mud/icons cvs server: Diffing gnome-mud/intl cvs server: Diffing gnome-mud/macros cvs server: Diffing gnome-mud/plugins cvs server: Diffing gnome-mud/plugins/python cvs server: Diffing gnome-mud/plugins/test.plugin cvs server: Diffing gnome-mud/po cvs server: Diffing gnome-mud/src Index: gnome-mud/src/net.c =================================================================== RCS file: /cvs/gnome/gnome-mud/src/net.c,v retrieving revision 1.75 diff -u -r1.75 net.c --- gnome-mud/src/net.c 11 Feb 2004 14:43:49 -0000 1.75 +++ gnome-mud/src/net.c 13 Mar 2005 09:04:20 -0000 @@ -423,7 +423,8 @@ { send (connection->sockfd, string, strlen(string), 0); } - + + string = NULL; g_free(string); #endif } cvs server: Diffing gnome-mud/src/pixmaps cvs server: Diffing gnome-mud/src/svg cvs server: Diffing gnome-mud/ui
Attachment:
signature.asc
Description: This is a digitally signed message part