[gnome.org #14133] Commit hook to check for i18n errors seems to be down

["Andrea Veri via RT" <gitmaster gnome org>]

On Mon Feb 03 15:42:58 2014, kelemeng gnome hu wrote:
> Hi
>
> I have just committed a syntactically broken hu.po into shotwell, and
> the git hook that is supposed to catch such errors let me to push it
> into the repository. This had the potential to break the build.
>
> Commit that fixed the breakage:
> https://git.gnome.org/browse/shotwell/commit/po/hu.po?id=28e3f663186d5a4dbfc317fa80e4d7e29a0179f0
>
>
> (look at #: ../src/Dialogs.vala:738 and the next string
> Dialogs.vala:755 )
>
> Is it possible that the hook does not work? Can it be restored?

The hook was never removed or touched and the pre-receive hook is configured to make use of the following 
script [1], what I did to test this wasn't an issue on our side:

git clone git://git.gnome.org/shotwell.git
git reset --hard HEAD~2 (this reverted us back to the state of the git repository right after you committed 
the errors on the po file)
msgfmt -o log hu.po && echo $? --> returned 0, success

I then tried to remove a double quote, re-run the above command for testing and the result was obviously a 
failure that msgfmt catched.

I'm not sure I did understand what the error was in this case, can you please try to be more verbose?


-- 
Andrea,
GNOME Sysadmin
GNOME Accounts Team
GNOME Membership & Elections Committee Chairman


----------------------------------------------------
This message was sent via GNOME.org Request Tracker.