Re: doap:category check



On Tue, 2009-04-28 at 17:06 -0400, Owen Taylor wrote:
> On Tue, 2009-04-28 at 15:57 -0500, Shaun McCance wrote:
> > Right now, validate-doap is refusing any DOAP files that
> > have doap:category properties outside our doap-extensions
> > resources.  That's totally anti-RDF.  People can set all
> > sorts of properties, including multiple doap:category
> > properties for plenty of things besides our cgit.
> > 
> > There's also the issue that get_property in semi_rdf
> > always gives the first occurrence of a property.  So
> > if people do have multiple categories (and I see no
> > reason to expect they shouldn't), they would have to
> > make sure the Gnome one is first.  Fragile.
> > 
> > Attaching a patch that should fix both these issues.
> > Please test.  It's hard for me to test this stuff
> > well without access to our cgit installation.
> 
> Two comments here:
> 
>  1) It's probably better to add a get_properties() to
>     semi_rdf.py that returns a list of all matched
>     Could be used for the maintainers check in 
>     the validation as well.
> 
>  2) I don't think we should entirely skip the validation;
>     because people will a) make typos (Say use #binding
>     instead of #bindings) b) make up stuff
>     like:
> 
>     http://api.gnome.org/doap-extensions#music-player
> 
>     So, the compromise would be to check that if it starts
>     with http://api.gnome.org/doap-extensions it has
>     to be one of our real categories.

Both sound reasonable.  I'll try to cook up
a new patch later today.

--
Shaun




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]