Re: Wrong context in 2 strings



If the original string doesn't change and indeed it doesn't implies a change in the translated one (and avoids translators to review a fuzzy string) it's ok for me to apply the change directly in PO files.

Maybe other coordinators will disagree, but you have the OK to do it in the Spanish PO file ;-)

About the second question... don't know how often this issues are, but I would ask here before commiting, just to ensure you have the OK from the i18n community.

Thanks!

El jue., 7 feb. 2019 a las 16:12, Jehan Pagès via gnome-i18n (<gnome-i18n gnome org>) escribió:
Hi!

In GIMP, we had a small bug in 2 strings: "Grow lighter areas of the image" and "Grow darker areas of the image".

Basically in our code, we declared the strings with "drawable-action" context (hence that was the msgctx registered in po files) but called the translation with "filters-action" context so they were not translated.
I fixed the code to use "filters-action" everywhere (the other was wrong), but the wrong context is now in various po/*.po files (43 files).

Do you mind if I just do a massive search-and-replace for these 2 context/strings to fix them? I mean, I actually already did it locally (took 20 secs), and I think that it is simpler than having everyone just edit manually for what was basically just a code bug. The actual context is the same (these strings are filter descriptions, same place in the GUI as what they were, nothing changed GUI-wise). So that looks harmless to me.

Yet I have been told we should not touch the po files ourselves, if possible.

So 2 questions:
1/ Is it ok if I just push this change?

2/ In the future, what should be our process as developers when we just see these kinds of code issues affecting the po files? Can we just push (making our own decision that this is not a translation issue) or we must ask case by case?

Thanks for the awesome work, all!

Jehan

_______________________________________________
gnome-i18n mailing list
gnome-i18n gnome org
https://mail.gnome.org/mailman/listinfo/gnome-i18n


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]