Re: freeze break requests for gnome-initial-setup

[Frederic Peters <fpeters gnome org>]

Javier Jardón wrote:

> On 17 September 2014 01:44, Matthias Clasen <matthias clasen gmail com> wrote:
> > gnome-initial-setup is getting some attention. Unfortunately it is
> > very late in the cycle, but better late than never.
> >
> > https://bugzilla.gnome.org/show_bug.cgi?id=734808 has a few patches
> > from Allan and myself which help addressing window size issues for
> > gnome-initial-setup. It was coming up taller than 768 pixels. The main
> > size reduction patches have already gone into the release I made
> > yesterday for .92. Whats left there now is some cosmetic cleanup
> > patches to adjust padding and alignment on some of the pages.  These
> > can be safely deferred until .1, but the patches are pretty safe.
>
> Id like to have an screenshot, but I trust you and Allan that the
> final result looks good
> Only for curiosity; What is the final size in pixels?

I can't give the precise number but given comment 12 it will probably
be around 760px, Bastien asked for 600px (that was a common height of
netbooks) but that's not considered doable without much larger
changes.

> 1/2 for release team

2/2.



> > https://bugzilla.gnome.org/show_bug.cgi?id=736764 has patches by Rui
> > to remove filtering of IBus input sources. This follows a similar
> > patch that we've applied in .91 to remove filtering of keyboard
> > layouts - the idea here is that if the user asks to see more input
> > sources by clicking on the more button, it is better to show all we
> > have than to possibly filter out the one input source he was looking
> > for. This patch removes an annoyance that has been reported in the
> > Fedora 21 GNOME test day - not super-important, but nice to have.
>
> Patches are small and its a good improvement to complete the work
> started in #729208.
> 1/2 for release team

I would be the maintainer I would nitpick as there are places where
indendation is made using spaces while the rest of the file is using
tabs.

But 2/2 nevertheless.


> > https://bugzilla.gnome.org/show_bug.cgi?id=736763 has patches also by
> > Rui to fix a bug wrt to locale changes - we were not actually showing
> > the right input sources for the locale that the user just selected.
> > This is a case where our well-intentioned attempt to show the relevant
> > input sources has backfired to create confusion that actively prevents
> > users from finding their input source. We should take this one.
>
> Small patch and makes sense
> 1/2 for release team

2/2.


Of course it would be nice if a .92 tarball could be created soon
enough to be included in the release.


        Fred