Re: Boxes string change

["Zeeshan Ali (Khattak)" <zeeshanak gnome org>]

On Mon, Mar 4, 2013 at 11:53 PM, Piotr Drąg <piotrdrag gmail com> wrote:
> 2013/3/4 Zeeshan Ali (Khattak) <zeeshanak gnome org>:
> > Hi,
> >   We changed some string in Boxes just before 3.7.91:
> >
> > https://bugzilla.gnome.org/show_bug.cgi?id=695111
> > http://git.gnome.org/browse/gnome-boxes/commit/?id=1411ba951cf51443f4e4e26a0fa0ef0584585764
> > http://git.gnome.org/browse/gnome-boxes/commit/?id=f0f3d771a8ba0d4353aa7a78a5a14311fe83fdf6
>
> Hi,
>
> Please don't split string like this:
>
> machine.got_error (_("Insertion of '%s' as a CD/DVD " +
> "into '%s' failed").printf (path_basename,
>
> This way only the first part of the string ends being translated.

Yikes, I only remembered that vala automatically puts them together in
generated C files but forgot the fact that we scan .vala files from
translations, not C. :(


-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124