Re: [gnome-flashback] Broken parts of GNOME Flashback with GNOME 3.12



Hi,

I tested your fixes with GNOME 3.14.

1. Incompatibility with gnome-settings-daemon's cursor plugin >= 3.10

Currently the mouse cursor is invisible, because GSD's cursor plugin
expects that the cursor is initialised by the window manager. Related
commit:

https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=bef5cd776266873285ee1d1004332fbbc3ec1b91

I guess we need something from the MetaCursorTracker code in mutter,
but I'm not sure:
https://git.gnome.org/browse/mutter/log/?qt=grep&q=MetaCursorTracker


You might be right. I am thinking that it might have something to do with
MetaIdleMontitor too. But it is not going to be added to metacity, but to
gnome-flashback module.

My idea is simple - if something is removed and/or moved to mutter or
gnome-shell then we add it to gnome-flashback module. I don't want to make
metacity to became very similar to mutter.


I have updated gnome-flashback module. It still needs some extra work, but
idle-monitor should work. After logging in session mouse cursor will be
hidden by gnome-settings-daemon's cursor plugin. Cursor will show after first
mouse movement and/or mouse button click.

Thanks, it works very well!

3. Clicking on the Clock applet causes an immediate crash


It is not crashing for me. Do you have more info?

It's strange, but I can't reproduce it any more with the latest code
in GNOME 3.14.

gnome-applets
-------------

4. The Weather applet crashes randomly when I open its preferences, or
when I type my location, „Budapest”.


It is crashing when trying to open preferences dialog or updating whether
for second time. But it is not crashing when typing 'Budapest'. I am quit
busy at least for few weeks. When I will have more time will try to fix.

Can you please test it again? I pushed two fixes for gweather applet.

You fixed it, thanks!

5. The Invest applet is broken, unable to add it to the panel, no error
message.


Interesting. It is working for me in jhbuild session (GNOME 3.14) and on
ubuntu 14.10.

Okay, I found the problem: it's unable to import 'defs' for some
reason. I attached a patch that fixes the problem. It also fixes
opening help.

7. Incompatibility with gnome-settings-daemon's media keys plugin >= 3.8

Currently the media keys (along with many other keyboard shortcuts)
don't work, because GSD's media keys plugin expects that the keyboard
events are grabbed by the shell. Related bugzilla tasks:
gnome-settings-daemon: https://bugzilla.gnome.org/show_bug.cgi?id=693016
gnome-shell: https://bugzilla.gnome.org/show_bug.cgi?id=643111

But even if we implement the above, the OSD is not visible on events
(e.g. when set the volume level), because it's also relying on the
shell now. Related bugzilla tasks:

gnome-settings-daemon: https://bugzilla.gnome.org/show_bug.cgi?id=695021
gnome-shell: https://bugzilla.gnome.org/show_bug.cgi?id=613543

Therefore we either need to implement these D-Bus interfaces within
gnome-flashback, or we need to fork somehow GSD's media keys plugin.


That something that we will need include in gnome-flashback. Added this to
my todo list.

Okay, I think it's not easy, but important task.

8. The background disappears on VT switch. Switching with Ctrl+Alt+F12
then back causes black background. When I move the windows, the
background becomes visible again behind them.

9. The background is missing with mutter. Just run 'mutter --replace',
and you will see an ugly lightgreen background instead of the selected
background image.

I have updated background drawing. Can you test it?
1) There should not be lightgreen background with mutter.
2) Background might not disappear after VT switching (did not test).
3) There will be fade effect when changing background.

I can't see the fade effect, but anyway, it works well. Thanks!

10. Missing volume control systray icon

The GNOME fallback mode had a nice volume control applet, which was
provided by gnome-control-center. So the following code should be
added back to the gnome-flashback project:
https://bugzilla.gnome.org/show_bug.cgi?id=682861

https://git.gnome.org/browse/gnome-control-center/commit/?id=94506721aa1fd463ff92f23ef0bf7cf50813a260


Ok, but than I think we could remove mixer applet from gnome-applets, right?

Do you want test? I have added this to gnome-flashback module.

It works, but the tray icon is invisible (probably a theme issue with
GNOME 3.14, we need to discuss it in another thread).

And yes, you can drop the mixer applet now. It's not built by default,
just a leftover from GNOME 2 ages.

11. Missing automount helper

The GNOME fallback mode had a mount helper application, which was
provided by gnome-settings-daemon. So the following code should be
added back to the gnome-flashback project:
https://bugzilla.gnome.org/show_bug.undocomentedcgi?id=682859

https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=77a29fde9204a80ad3960fc6d50a733261fbfbfe


Added to todo list.

It should be a simple task to integrate it into gnome-flashback as a
module, because it was originally a small binary. It was removed
entirely from gnome-settings-daemon, because the equivalent
functionality was reimplemented in GNOME Shell. So you can add the
code as is.

12. Missing other components

The GNOME fallback mode had the following additional project, which
are now unmaintained:
- gnome-screensaver
- notification-daemon
- polkit-gnome

I think that all of them should be launched on login (as it was
happened in fallback mode), either by adding them as required
components to the session file (therefore the user cannot easily
replace them), or by implementing a configurable launcher within
gnome-flashback.


I don't like idea about adding to required components.

We need to autostart them in some ways to provide a complete desktop
session by default. Ideas:
1. Launch components from the gnome-flashback binary in an optional
and configurable way, so users could disable each component in
GSettings.
2. Add .desktop autostart files for each component with
'AutostartCondition=GNOME3 if-session gnome-flashback'.
3. Add them to RequiredComponents= line of the session file.

I would prefer the first option. What do you think?

--
György Balló
Arch Linux Trusted User

Attachment: fix-invest-applet.patch
Description: Text Data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]