Am 04.06.2014 11:57 schrieb "Alberts Muktupāvels" <alberts muktupavels gmail com>:
>>
>> > Maybe there are patches in debian and ubuntu that should be applied to
>> > master? Dmitry?
Thanks for applying the patches :)
>> There are two patches in Debian:
>>
>> - 01_focus_new_window.patch — https://bugzilla.gnome.org/show_bug.cgi?id=534752
>
>
> I was able to reproduce bug. Fixed.
>
>>
>> - 03_gtop_error.patch — https://bugzilla.gnome.org/show_bug.cgi?id=603240
>
>
> I can not reproduce bug. Launching from terminal it it does not add "(as superuser)" text. Does this patch is really needed? Can someone confirm that this is still bug or is not?
I did not try to reproduce this. Looking at the patch, it covers some rare case (when gtop returns an error), so it's probably hard to reproduce it.
>> I think both can be applied in master.
>>
>> There are 13 other patches in Ubuntu (that are not already applied upstream).
>>
>> Here are ones that look suitable for upstream:
>>
>> - 04_support_drag_drop_with_alt_tab.patch —
>> https://bugzilla.gnome.org/show_bug.cgi?id=135056
>
>
> Fixed.
>
>>
>> - 10_no-ws-switcher.patch — https://bugzilla.gnome.org/show_bug.cgi?id=609513
>
>
> Fixed.
>
>>
>> - 13_better_support_for_button_layout.patch —
>> https://bugzilla.gnome.org/show_bug.cgi?id=608511
>
>
> Will try to look at it later.
>
>>
>> - 14_wrong_colormap.patch (not forwarded)
>
>
> Not needed. GdkColormap does not exist in gtk3.
>
>>
>> - 22_fix_above_tab_switching.patch —
>> https://bugzilla.gnome.org/show_bug.cgi?id=692437
>
>
> This patch does not work with master.
>
>>
>> - 100_fade_on_long_title.patch —
>> https://bugzilla.gnome.org/show_bug.cgi?id=642108
>
>
> Fixed.
>
>> Other 7 patches look Ubuntu-specific. Some of them were needed for
>> Unity 2D, so can probably be dropped now.
>
>
> What you think about 06_Add_UXD_shadows_and_borders.patch? Without it Ambiance theme does not work.
It works here without that patch (my PPA doesn't have any patches from Ubuntu). Also, the second hunk has many occurancies of "unity_" prefix, so I think it's only sensible on Ubuntu.
--
Dmitry Shachnev