Hi Dmitry, On 30/05/14 09:27, Dmitry Shachnev wrote:
On Thu, May 29, 2014 at 2:17 AM, Lanoxx <lanoxx gmx net> wrote:Can somebody run a symbol breakage test ? Otherwise I'll have to investigate myself, but it will take me a few days to get to it.How can I test this? Are there tools that can verify this?I have just done that, but for the future, run: nm -D ./libpanel-applet/.libs/libpanel-applet-4.so
When I try this I notice two things:* nm also prints undefined symbols, wouln't it make more sense to just check defined symbols (--defined-only)? It also seems that some undefined symbols change when I compare the two versions (master and 3.8.0). For example:
@@ -128,6 +127,8 @@
U g_printerr
U g_resources_lookup_data
U g_return_if_fail_warning
+ U g_settings_get_string
+ U g_settings_new
I am not sure what that means.
* The symbol values also change. What are the effects of symbol value
changes on the ABI?
and compare output for old and new versions. If something is removed, then it is an ABI break.
I have attached a patch to partially revert the changes. Alberts says that these two methods are not part of the public API. And given that the file panel-applet-bindings.h is not contained in libpanel_appletinclude_HEADERS I tend to agree. These functions are also not documented.
Cheers Sebastian
-- Dmitry Shachnev _______________________________________________ gnome-flashback-list mailing list gnome-flashback-list gnome org https://mail.gnome.org/mailman/listinfo/gnome-flashback-list
Attachment:
0001-Partially-revert-commit-c96e85f3.patch
Description: Text Data