Re: [gnome-flashback] Patch to remove libegg (EggSMClient)

[Alberts Muktupāvels <alberts muktupavels gmail com>]

eggdesktopfile.c do some thing as we will do it without it:

gtk_window_set_default_icon_name (egg_desktop_file->icon);

I don't see any need to test it. In both cases icon name is set with gtk_window_set_default_icon_name function.

In gnome-panel.desktop icon name is gnome-panel.

In panel-icon-names.h icon name is gnome-panel.

egg desktop file offers option to use icon with full path, but we don't use it. MATE does not use it too.

--
Alberts Muktupāvels

On Thu, Oct 24, 2013 at 2:59 AM, Philipp Kaluza <floss ghostroute eu> wrote:

Am 06.10.2013 11:31, schrieb Alberts Muktupāvels:
> Created new patch which is attached to bug I created. It will only
> remove EggSMClient.
That bug, for reference, is
https://bugzilla.gnome.org/show_bug.cgi?id=709495 .
Like I wrote in the review, no need to move eggdesktopfile.[ch] into the
upper directory.

>     We also have EggDesktopFile. Could you write a few lines how we
>     use this
>     and what is the recommended replacement ?
>
>
> If I am not wrong than we are using it only to set application name
> and icon. So I am saying it is safe to remove it too. We dont need
> thousand lines to do this simple job. Replacement it already in code -
> when egg fails to get desktop file it sets name and icon to default.
> If you and others agree I can create extra patch to remove this too.

I see that you removed it in your github branch (in commit
https://github.com/albertsmuktupavels/gnome-panel/commit/ce5765a6df6f83575e1d734aa6b7ace913aee7d0
).

Could you test if this works reliably even in corner cases, e.g. if
gnome-settings-daemon is not running and cannot set icon theme ?

Cheers
  Philipp

--
Philipp Kaluza
Ghostroute IT Consulting