Re: [gnome-flashback] Patch to remove libegg (EggSMClient)

[Alberts Muktupāvels <alberts muktupavels gmail com>]

Hi, Lannoxx,

Because it is old, it uses deprecated functions which sooner or later will cause problems.

Hi, Philipp,

Again I almost replied to you directly. On your e-mails when I press reply it will reply to you directly not to mailing list. :(

Created new patch which is attached to bug I created. It will only remove EggSMClient.

We also have EggDesktopFile. Could you write a few lines how we use this
and what is the recommended replacement ?

If I am not wrong than we are using it only to set application name and icon. So I am saying it is safe to remove it too. We dont need thousand lines to do this simple job. Replacement it already in code - when egg fails to get desktop file it sets name and icon to default. If you and others agree I can create extra patch to remove this too.

--
Alberts Muktupāvels

On Sun, Oct 6, 2013 at 12:40 AM, Lanoxx <lanoxx gmx net> wrote:

Hi Alberts,

I just read through your patch. As I am not yet so familiar with the
gnome-panel code, could you maybe explain what the functionality of this
old code (EggSMClient) was and why it is being removed?

Kind Regards
Sebastian

On 05/10/13 20:43, Alberts Muktupāvels wrote:
> Hi All!
>
> Attached patch which removes libegg (EggSMClient).
> * Last commit in git is almost year ago. (https://git.gnome.org/browse/libegg/)
> * It is not ported to gtk3. At least comment #37 says it needs to be
> done. (https://bugzilla.gnome.org/show_bug.cgi?id=79285)
> * Other gnome apps have done it already. For example gnome-terminal.
> (https://mail.gnome.org/archives/commits-list/2012-May/msg01572.html)
>
> --
> Alberts Muktupāvels
>
>
>

> _______________________________________________
> gnome-flashback-list mailing list
> gnome-flashback-list gnome org
> https://mail.gnome.org/mailman/listinfo/gnome-flashback-list
>
_______________________________________________
gnome-flashback-list mailing list
gnome-flashback-list gnome org
https://mail.gnome.org/mailman/listinfo/gnome-flashback-list