Re: gnome-documents: Use header bars in dialogs (726343)

[Ekaterina Gerasimova <kittykat3756 gmail com>]

(Dropping the release team form the CC as this is only docs related)

On 16 March 2014 14:17, alex diavatis <alexis diavatis gmail com> wrote:
> > Hi, I fixed this in master earlier today (which is why I came across your
> > bug)
>
> I compiled Documents before I filed the bug, included your last changes. But
> I still get the old docs in Yelp :/
> However I now looked into your changes in source. Anyway, my bad, sorry!

You don't need to compile the help to view it: just run 'yelp help/C/'
when in your repository clone. If you actually want the help button to
go to the latest help when you build from master, then you either need
to install it or use jhbuild.

> On Sun, Mar 16, 2014 at 3:49 PM, Ekaterina Gerasimova
> <kittykat3756 gmail com> wrote:
> > On 16 March 2014 13:28, alex diavatis <alexis diavatis gmail com> wrote:
> > > I just filed a bug about gnome-documents help. If you make changes in
> > > Help,
> > > maybe you can correct also this.
> > >
> > > https://bugzilla.gnome.org/show_bug.cgi?id=702781#c2
> > >
> > > In "Make collections of documents"
> > > There is a note:  "Click the Trash button in the button bar. The
> > > collection
> > > will be deleted, leaving the original documents."
> > >
> > > In "Selective Documents" There is a note:  "Delete (trash icon): delete
> > > one
> > > or more collections"
> > >
> > > GNOME Documents 3.12 doesn't have any "Trash Icon", just a "Delete",
> > > text
> > > button.
> >
> > Hi, I fixed this in master earlier today (which is why I came across
> > your bug). The newest help will be on the website from late tomorrow
> > night as long as the release is made on time:
> > https://help.gnome.org/users/gnome-documents/unstable/
> >
> >
> >
> > > On Sun, Mar 16, 2014 at 12:28 PM, Ekaterina Gerasimova
> > > <kittykat3756 gmail com> wrote:
> > > > On 16 March 2014 00:28, Andre Klapper <ak-47 gmx net> wrote:
> > > > > On Sat, 2014-03-15 at 12:36 -0400, Matthias Clasen wrote:
> > > > > > On Sat, Mar 15, 2014 at 4:07 AM, Debarshi Ray <rishi is lostca se>
> > > > > > wrote:
> > > > > > > Hello everybody,
> > > > > > >
> > > > > > > We have a patch to make gnome-documents use header bars in dialogs
> > > > > > > like the stock GTK+ dialogs and custom dialogs in other core
> > > > > > > modules:
> > > > > > >   https://bugzilla.gnome.org/show_bug.cgi?id=726343
> > > > > > >
> > > > > > > The dialogs affected by this are:
> > > > > > >  - PasswordDialog: used to ask for passwords of encrypted
> > > > > > > documents
> > > > > > >  - PropertiesDialog: used for "Properties" that can be accessed
> > > > > > > from
> > > > > > >    the gear menu and the action bar
> > > > > > >  - OrganizeCollectionDialog: used to add/remove items to
> > > > > > > collections
> > > > > > >  - SharingDialog: use to change the sharing permissions of Google
> > > > > > >    content
> > > > > > >
> > > > > > > As far as I can make out there are no affected screenshots in the
> > > > > > > user
> > > > > > > help.
> > > > > > >
> > > > > > > I would like to request a UI Freeze exception to commit this.
> > > > > >
> > > > > > IF the documentation is not affected, that seems fine to me. +1 for
> > > > > > the release team.
> > > > >
> > > > > And the second +1 from r-t, assuming that docs is fine with this.
> > > > > Docs?
> > > >
> > > > The documentation is affected, but I will be updating it today anyway.
> > > > If the only change is that the buttons which are currently at the
> > > > bottoms of dialogs are moving up to the top, then I will just make
> > > > sure to not mention where they are.
> > > > _______________________________________________
> > > > release-team gnome org
> > > > https://mail.gnome.org/mailman/listinfo/release-team
> > > > Release-team lurker? Do NOT participate in discussions.