Request to break hard code freeze to fix Tomboy crasher


Recently bug #475516 was reported for Tomboy, basically stating that
the first time Tomboy is started (as an applet) after a user creates
note with the old Sticky Notes applet, Tomboy's Sticky Notes Import
addin causes Tomboy to crash.

Attached is the proposed fix, which solves the problem by only showing
the import results dialog if the user explicitly initiates an import
through the Tools menu.  This is a very minor UI change that should
not affect the documentation.

I request to break hard code freeze in order to apply this patch.  I
believe this is a very important bug to fix considering that several
distros ship with Tomboy in the panel by default.


Index: Tomboy/Addins/StickyNoteImport/StickyNoteImportNoteAddin.cs
--- Tomboy/Addins/StickyNoteImport/StickyNoteImportNoteAddin.cs	(revision 1509)
+++ Tomboy/Addins/StickyNoteImport/StickyNoteImportNoteAddin.cs	(working copy)
@@ -91,7 +91,8 @@
 				XmlDocument xmlDoc = GetStickyXmlDoc ();		
 				if (xmlDoc != null)
-					ImportNotes (xmlDoc);
+					// Don't show dialog when automatically importing
+					ImportNotes (xmlDoc, false);
@@ -119,7 +120,7 @@
 			XmlDocument xmlDoc = GetStickyXmlDoc ();
 			if (xmlDoc != null)
-				ImportNotes (xmlDoc);
+				ImportNotes (xmlDoc, true);
 				ShowNoStickyXMLDialog (sticky_xml_path);
@@ -147,7 +148,7 @@
-		void ImportNotes (XmlDocument xmlDoc)
+		void ImportNotes (XmlDocument xmlDoc, bool showResultsDialog)
 			XmlNodeList nodes = xmlDoc.SelectNodes (sticky_note_query);
@@ -165,7 +166,8 @@
-			ShowResultsDialog (numSuccessful, nodes.Count);
+			if (showResultsDialog)
+				ShowResultsDialog (numSuccessful, nodes.Count);
 		bool CreateNoteFromSticky (string stickyTitle, string content)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]