Re: Request for UI break in gedit-plugins



On Wed, 2007-09-05 at 10:40 -0300, Jonh Wendell wrote:
> Em Qua, 2007-09-05 �10:08 -0300, Jonh Wendell escreveu:
> > Hi.
> > 
> > Since gtk 2.12, the key F7 is used by gtk in textview widget [1].
> > 
> > As spell checker gedit plugin uses that key, i've changed it to use
> > Shift-F7 instead of just F7. [2]
> > 
> > That keybinding is specified on gedit manual, section "Shortcut keys",
> > so it has to be updated.
> > 
> > [1] - http://bugzilla.gnome.org/show_bug.cgi?id=380048
> > [2] - http://bugzilla.gnome.org/show_bug.cgi?id=472371
> > 
> > Thanks,
> 
> Update: I've created a new patch where i also update the gedit help.

You need two release team approvals, and I'm not one of
them.  But this is a documentation team approval, if any
release teamers depend on that.

1) The F7 keybinding no longer works.  So without the
   patch, the documentation would be wrong anyway.
2) Your latest patch fixes the documentation as well.
3) It is *very* unlikely that any other documentation
   is affected.

So that's an OK from me.

--
Shaun






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]