Re: new, little patch and some questions

[aurelien naldi <aurelien resus univ-mrs fr>]

Le jeu 04/12/2003 à 01:58, John (J5) Palmieri a écrit :
> On Wed, 2003-12-03 at 14:06, Markus Bertheau wrote:
> >  , 03.12.2003,  12:47, aurelien naldi :
> > > Le mer 03/12/2003  10:13, Markus Bertheau a crit :
> > > 
> > > sorry, here are corrected patches
> > 
> > I am not a scaffold developer, but the following line certainly needs
> > explanation:
> > 
> > -       gbf_project_clean (proj_tool->project, &err);
> > +       //gbf_project_clean (proj_tool->project, &err);
> 
> I would second this.  Is the gbf_project_clean method not working?  A
> project should be cleaned before it is compiled or at least there should
> be an option.  Perhaps we need a Clean Build menu item.  

look at the next line:

-       gbf_project_clean (proj_tool->project, &err);
+       //gbf_project_clean (proj_tool->project, &err);
+       gbf_project_build (proj_tool->project, "clean", &err);

the third one will run a "make clean", gnome-build seems to run many
differents call from within gbf_project_build (even if effective call
wasn't done before, see the second patch): make with various arguments,
configure and perhaps other to come.

this is linked to the "cleanup build files" entry of the project menu
ain't it what you want ?

perhaps it should use gbf_project_clean instead but those two function
would do nearly the same job (except that gbf_project_clean don't need
the "clean" argument), I can fill this function and change the call if
you prefer, or perhaps should all those function (gbf_project_clean,
gbf_project_build..) just call a gbf_project_run_op function which would
do the real job ?

As I'm not really familiar with your code base I don't know in wich
direction to go. For the moment I mainly wanted to make it work and see
if you were ready to discuss a bit, I'm happy to see so many answer :)

-- 
aurelien