Re: [gnome-db] recent GSEAL addition

[Daniel Espinosa <esodan gmail com>]

I've added documention to set Since: tags. Added symbols to
libgda.symbols and apply some coding styles. See at:

http://git.gnome.org/browse/libgda/commit/?id=dda8de22e9f0b2e173694c34a154041a4c92acd3

2011/11/11 Daniel Espinosa <esodan gmail com>:
> 2011/11/11 Murray Cumming <murrayc murrayc com>:
>> Is this API change appropriate in the stable libgda 5.0?
>> http://git.gnome.org/browse/libgda/commit/?id=3b5c67b0535093c91b32dfa08bb02b9f9b39474b
>>
>> Hopefully the use of GSEAL just makes it an API (rather than ABI)
>> change, but still, it is unexpected.
>
> GSEAL() macro doesn't modify API/ABI. Any one compiling the source
> doesn't note any change nor applications using it. This macro is a
> convenience at compile time and is just to check if you are using the
> accessors not direct access to the sealed struct.
>
> In order to see if the applications aren't using the now opaque struct
> of GdaNumeric's members, when you compile with
>
> make CFLAGS+="-DGSEAL_ENABLE"
>
> any code accessing directly to GdaNumeric members will fail at compile
> time. You'll advised to use accessors.
>
> GDA master doesn't compile with GSEAL_ENABLE. This will be a process,
> first fixing gda-value.c/.h and then providers.
>
> I need to add documentation in order to explain this.
>
>>
>> The new functions should have @since tags in their documentation.
>>
>
> I'm so sorry, I'll take care to add this tags and other
> recommendations made by Vivien on codding.
>
>> --
>> murrayc murrayc com
>> www.murrayc.com
>> www.openismus.com
>>
>> _______________________________________________
>> gnome-db-list mailing list
>> gnome-db-list gnome org
>> http://mail.gnome.org/mailman/listinfo/gnome-db-list
>>
>